-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide UI backward compatibility for older lxd versions [WD-8671] #647
Conversation
Demo starting at https://lxd-ui-647.demos.haus |
Things to think about
|
d1f6dd8
to
2f3039a
Compare
I am not sure how much 4.0 is still in use. I took this on our sync agenda for tomorrow, we can get more input from the core team on which lowest version to support. Likewise, I was previously under the impression 5.0 is fine. |
Aah great, thanks I was thinking about asking that tomorrow as well! I think if I know what the baseline lxd version is, then I can streamline the process to make this happen |
e4144a7
to
73da0aa
Compare
Will update PR notes in the morning. |
73da0aa
to
86ea5c3
Compare
198cc5c
to
e46c319
Compare
e46c319
to
8b8cca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA looks good, tested with 5.0 and a recent backend.
I found one issue and some small optional comments on code simplifications below.
8b8cca0
to
b6973ca
Compare
Signed-off-by: Mason Hu <[email protected]>
b6973ca
to
4743a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for applying the fixes :)
Done
/1.0/metadata/configuration
endpoint/documentation
api endpointfeatures.networks.zones
project config for lxd 5.0features.storage.buckets
project config for lxd 5.0QA
/documentation/objects.inv.txt
endpoint