-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: workaround for vite5 not working on s390x platform arch [WD-8319] #656
Conversation
Signed-off-by: Mason Hu <[email protected]>
Demo starting at https://lxd-ui-656.demos.haus |
This is a hack workaround, also difficult to test the final build output for s390x arch since we can't really run an multi-platform image locally. Not sure if I can find an alternative either than waiting for rollup to support s390x (or figure out a fix for rollup which will take a while). Below is an example build output from the project Dockerfile:
|
I think we should avoid having a different version of Vite depending on the build architecture. This creates a can of future complexity if we see any issues for that architecture that will be hard to manage. Better iterate on the upstream PR to fix roll-up. We don't have a strong incentive to go to Vite 5 and can stay on Vite 4 until it is resolved. |
Okay, I will close this PR for now, I'd like to focus a bit more on other tasks than going down a rabbit hole to get this resolved. I think in the meantime I will watch the upstream PR for this. |
Done
QA