Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge playwright reports with assets #660

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Feb 20, 2024

Done

  • Fixed issue where assets (videos/traces) are not attached to the html playwright report

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Ensure CI passes
    • Ensure videos and traces are in failing tests

@webteam-app
Copy link

Demo starting at https://lxd-ui-660.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mas-who
Copy link
Collaborator Author

mas-who commented Feb 20, 2024

might take a bit time to simulate failed tests, here is an example output for playwright report with failed tests: https://canonical.github.io/lxd-ui/reports/pr-660/7972395670/1/

@edlerd
Copy link
Collaborator

edlerd commented Feb 20, 2024

Thanks for fixing, the video looks good now in this report. Though, the trace is missing some styles (In the report click on retry #1, then on the trace).

@mas-who
Copy link
Collaborator Author

mas-who commented Feb 20, 2024

Thanks for fixing, the video looks good now in this report. Though, the trace is missing some styles (In the report click on retry #1, then on the trace).

Yeah that's a strange one, I see the css styling is just missing in the gh-pages branch. The executed playwright commands and folder structure is exactly the same now between my local environment and runner environment. Maybe it's the node version, going to see if bumping it up to v20 works.

@mas-who mas-who force-pushed the fix-playwright-merge-reports branch 12 times, most recently from 94329e0 to 95328b3 Compare February 20, 2024 17:25
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and code looks good. 👍

@edlerd edlerd merged commit 09f5662 into canonical:main Feb 20, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants