-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merge playwright reports with assets #660
Conversation
Demo starting at https://lxd-ui-660.demos.haus |
466d66f
to
090a71b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
might take a bit time to simulate failed tests, here is an example output for playwright report with failed tests: https://canonical.github.io/lxd-ui/reports/pr-660/7972395670/1/ |
Thanks for fixing, the video looks good now in this report. Though, the trace is missing some styles (In the report click on retry #1, then on the trace). |
090a71b
to
6423825
Compare
Yeah that's a strange one, I see the css styling is just missing in the gh-pages branch. The executed playwright commands and folder structure is exactly the same now between my local environment and runner environment. Maybe it's the node version, going to see if bumping it up to v20 works. |
94329e0
to
95328b3
Compare
Signed-off-by: Mason Hu <[email protected]>
95328b3
to
7fd013b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA and code looks good. 👍
Done
QA