Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use action button for a consistent loading button behaviour with vanilla guidelines #663

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Feb 21, 2024

Done

  • replace all occurrences of submit button with action button, to have a consistent loading button behaviour with vanilla guidelines
  • remove submit button component

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check occurrences of the submit button for visual regressions

@webteam-app
Copy link

Demo starting at https://lxd-ui-663.demos.haus

…ave a consistent loading button behaviour with vanilla guidelines

Signed-off-by: David Edler <[email protected]>
@mas-who
Copy link
Collaborator

mas-who commented Feb 22, 2024

code looks good, spot QA'd a few places where SubmitButton was replaced and it also looks good 👍 let's wait for @piperdeck for the design review

@edlerd edlerd merged commit cc03dbd into canonical:main Feb 26, 2024
10 checks passed
@edlerd edlerd deleted the deprecate-submit-btn branch February 26, 2024 09:31
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants