Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter volume snapshots on selecting custom volume #778

Merged
merged 1 commit into from
May 23, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented May 23, 2024

Done

  • Filter volume snapshots on selecting custom volume to add to an instance or profile. only show the custom volumes to select from.

Fixes #777

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Create a custom storage volume
    • Create snapshots of the volume
    • Go to configure instance, add disk device, select volume. Ensure the storage volume is available, but the snapshot is not.

@webteam-app
Copy link

@mas-who
Copy link
Contributor

mas-who commented May 23, 2024

LGTM, just the sign-off is missing.

…dd to an instance or profile. only show the custom volumes to select from. fixes canonical#777

Signed-off-by: David Edler <[email protected]>
@mas-who mas-who merged commit 130bb42 into canonical:main May 23, 2024
9 of 11 checks passed
@edlerd edlerd deleted the hide-volume-snapshots branch May 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide volume snapshot in "Choose custom volume" model
3 participants