Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation and editing of physical managed networks #792

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jun 5, 2024

Done

  • allow creation and editing of physical managed networks
  • add support for all ipv4, ipv6, dns and ovn options for physical networks
  • hide status from physical manage network overview, as they don't expose state.
  • change ip address selector label from "off" to "none" to be consistent with cli and internal naming.
  • disable instead of hide the ipv* nat option in the network main form. This is to avoid a "changed the number of rendered hooks" error.

Fixes WD-11519
Fixes #786

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • create and edit a physical managed network
    • create and edit a bridge network

@webteam-app
Copy link

@edlerd edlerd marked this pull request as draft June 5, 2024 17:03
@edlerd edlerd force-pushed the add-physical-managed-networks branch 2 times, most recently from dfb39ed to dae4f7f Compare June 6, 2024 11:27
@edlerd edlerd marked this pull request as ready for review June 6, 2024 11:28
@edlerd edlerd force-pushed the add-physical-managed-networks branch from dae4f7f to 52810a9 Compare June 6, 2024 14:46
Copy link
Contributor

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA looks good! Just a few minor comments

src/api/networks.tsx Show resolved Hide resolved
src/pages/networks/forms/NetworkFormDns.tsx Show resolved Hide resolved
src/pages/networks/forms/NetworkFormIpv4.tsx Show resolved Hide resolved
src/pages/networks/forms/NetworkFormIpv6.tsx Show resolved Hide resolved
src/pages/networks/forms/NetworkParentSelector.tsx Outdated Show resolved Hide resolved
tests/networks.spec.ts Show resolved Hide resolved
@edlerd edlerd force-pushed the add-physical-managed-networks branch from 52810a9 to 6057931 Compare June 10, 2024 14:22
@edlerd edlerd requested a review from mas-who June 10, 2024 14:22
@mas-who
Copy link
Contributor

mas-who commented Jun 10, 2024

LGTM 👍

@edlerd edlerd merged commit a42ff46 into canonical:main Jun 10, 2024
12 checks passed
@edlerd edlerd deleted the add-physical-managed-networks branch June 10, 2024 15:19
github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error report
4 participants