Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-11660] LXD-UI e2e test for operations #793

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Jun 7, 2024

Done

Created a test case in the new file operations.spec.ts to cover the following instance operations:

  • create an instance
  • validate create operation is in operation list
  • start instance
  • wait for the notification instance was started
  • click on the “x operations” link in the status bar
  • validate the operation to start the instance is in the operation list
  • on instances page: stop instance
  • validate stop operation is in operation list
  • delete instance
  • validate delete operation is in operation list

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • N/A

Screenshots

N/A

@Kxiru Kxiru requested review from edlerd and mas-who June 7, 2024 16:14
@Kxiru Kxiru self-assigned this Jun 7, 2024
@webteam-app
Copy link

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good already! Some comments to make this simpler below. The linter also has something.

tests/operations.spec.ts Outdated Show resolved Hide resolved
tests/operations.spec.ts Outdated Show resolved Hide resolved
tests/operations.spec.ts Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the operations-e2e-tests branch 2 times, most recently from cd54b27 to b2b4b4c Compare June 7, 2024 17:10
tests/operations.spec.ts Outdated Show resolved Hide resolved
@Kxiru Kxiru marked this pull request as ready for review June 10, 2024 12:08
tests/operations.spec.ts Outdated Show resolved Hide resolved
tests/operations.spec.ts Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the operations-e2e-tests branch 2 times, most recently from 9f0e229 to b50f748 Compare June 10, 2024 16:43
@Kxiru Kxiru requested review from mas-who and edlerd June 10, 2024 16:43
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the tests.
Tiny nitpick below. Also, good to merge without it.

tests/operations.spec.ts Outdated Show resolved Hide resolved
tests/operations.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for driving this forward quickly.

@Kxiru Kxiru merged commit ce8d2e6 into canonical:main Jun 10, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
@Kxiru Kxiru deleted the operations-e2e-tests branch June 17, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants