-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WD-11660] LXD-UI e2e test for operations #793
Conversation
c0b3935
to
c65d2b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good already! Some comments to make this simpler below. The linter also has something.
cd54b27
to
b2b4b4c
Compare
b2b4b4c
to
3723b7e
Compare
9f0e229
to
b50f748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the tests.
Tiny nitpick below. Also, good to merge without it.
Signed-off-by: Nkeiruka <[email protected]>
b50f748
to
c2681dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for driving this forward quickly.
Done
Created a test case in the new file
operations.spec.ts
to cover the following instance operations:QA
Screenshots
N/A