Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WD-11889] LXD add e2e testing for doc links #795

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[WD-11889] LXD add e2e testing for doc links #795

merged 1 commit into from
Jun 12, 2024

Conversation

Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Jun 10, 2024

Done

  • chore(tests): added e2e testing for doc links

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • N/A

Screenshots

N/A

@Kxiru Kxiru requested review from edlerd and mas-who June 10, 2024 21:14
@Kxiru Kxiru self-assigned this Jun 10, 2024
@webteam-app
Copy link

Demo

Jenkins

demos.haus

edlerd
edlerd reviewed Jun 10, 2024
View reviewed changes
tests/doc-links.spec.ts Outdated Show resolved Hide resolved
tests/helpers/doc-links.ts Outdated Show resolved Hide resolved
edlerd
edlerd reviewed Jun 10, 2024
View reviewed changes
tests/doc-links.spec.ts Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the doc-link-e2e-tests branch 3 times, most recently from a45a418 to 2597424 Compare June 11, 2024 16:53
@Kxiru Kxiru requested a review from edlerd June 11, 2024 16:54
edlerd
edlerd approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some more ideas to improve the code below.

tests/doc-links.spec.ts Outdated Show resolved Hide resolved
tests/doc-links.spec.ts Outdated Show resolved Hide resolved
tests/helpers/doc-links.ts Outdated Show resolved Hide resolved
@Kxiru Kxiru requested a review from edlerd June 12, 2024 10:56
edlerd
edlerd approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes.

@Kxiru Kxiru marked this pull request as ready for review June 12, 2024 11:33
@Kxiru Kxiru merged commit be48794 into canonical:main Jun 12, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
workflow: remove all reports for PR #795
e3e55e6
@Kxiru Kxiru deleted the doc-link-e2e-tests branch June 17, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

@mas-who mas-who Awaiting requested review from mas-who

Assignees

@Kxiru Kxiru

Labels
Review: Code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kxiru @webteam-app @edlerd @mas-who