-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adjusted detail page titles for better ux consistency [WD-11696] #803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, this is much better than before.
I found two issues on QA
-
This was broken before, I just realized it now due to focus on the header: The loading behaviour of the instance and profile detail pages render the header briefly without the prefix. This is causing a jump in the UI, maybe we can change the loading behaviour to immediately render with the prefix? Also for invalid instance names we should render the header with prefix, currently the bare name is rendered:
5391234
to
55c13d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5157c39
to
96cd5b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA and code looks good, thanks for improving this.
There is one glitch, which existed previously, about spacing. I think adding the suggested classes will fix it: When in a screen with low height and going into the rename mode, previously the height of the header would grow, causing an additional scrollbar to appear. With the changes I am to keep the height unchanged.
- Addressed "lag" in loading time by only rendering the title when the instance has loaded. - Added breadcrumb header to invalid instance page. - Minor logic alterations to provide reasoning as to why invalid instances cannot be renamed. Signed-off-by: Nkeiruka <[email protected]>
96cd5b3
to
e970fd7
Compare
@edlerd , I added the |
looking good, nice job on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for improving the headers.
Done
QA
Screenshots