Update discovery form to use the new API and machine list box #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://maas-ui-4399.demos.haus |
|
@petermakowski I'm going to hold off reviewing this one until we're happy with the the other PR. |
petermakowski
commented
Sep 9, 2022
- spread SearchBox props - fix debounced typo - simplify machineFactory - add docstring comments
petermakowski
force-pushed
the
update-discovery-form-api-1112
branch
from
e4ebc8c
to
bb6d7d9
Compare
- handle onKeyPress within MachineSelectTable
Decided to merge this to the main PR #4389 as this isn't going to get reviewed today anyway and will make it easier for you to carry on working on this if it's all in a single branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Note: includes changes from: #4389 - that needs to be merged first.
QA
MAAS deployment
To run this branch you will need access to one of the following MAAS deployments:
Running the branch
You can run this branch by:
QA steps
Fixes
Fixes: https://github.com/canonical/app-tribe/issues/1112
Launchpad issue
Related Launchpad maas issue in the form
lp#number.Backports
In general, please propose fixes against main rather than release branches (e.g. 2.7), unless the fix is only applicable for that specific release. Please apply backport labels to the PR (e.g. "Backport 2.7") for the appropriate releases to target.
Only bug and security fixes should be backported, new features should only land in main.
Screenshots
It could be helpful to provide some screenshots to aid in QAing the change.