refactor(machines): MachineListTable to GenericTable MAASENG-5271#5814
Draft
abuyukyi101198 wants to merge 13 commits into
Draft
refactor(machines): MachineListTable to GenericTable MAASENG-5271#5814abuyukyi101198 wants to merge 13 commits into
abuyukyi101198 wants to merge 13 commits into
Conversation
Demo
Jenkins 
demos.haus 
# Conflicts: # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA steps
Fixes
Resolves MAASENG-5271
Notes
Machines table has many UX and feature flaws that do not disappear with this migration, because they are mostly caused by API-level features. Current v2 implementation has missing sorting features, and the overall UX design of the table forces the client to make repeated requests to the already sluggish v2 API. This PR will serve as a basis for the upcoming v3 implementation for machines, but shouldn't be merged until then.