Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK reference to snap version, drop version's patch #75

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

farshidtz
Copy link
Member

Summary

The following options have been considered:

Option 1

Don't use semver. In semver, the MINOR should change when the SDK changes. We can't easily automate that.

That gives us:

  • latest/stable: 2.0+chip-v1.3.0.0
  • latest/edge: 2.0+chip-hash

Option 2

Use semver's pre-release versioning on edge, and stable on releases.

That gives us:

  • latest/stable: 2.0.0+chip-1.3.0.0
  • latest/edge: 2.1.0-chip-hash (note the bumped MINOR and use of hyphen to indicate pre-release).

Option 2 was discarded as the manual versioning efforts are high and prone to human errors. Moreover, the snap doesn't require that level of details in the versioning.

Related to #74

Testing Steps

$ snapcraft -v
...
Creating snap package...                                                                                                                                 
Created snap package matter-pi-gpio-commander_2.0+chip-f6ac9266_arm64.snap 

Copy link
Contributor

@jpm-canonical jpm-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidtz farshidtz marked this pull request as ready for review June 19, 2024 15:30
@farshidtz farshidtz merged commit 5f3a195 into main Jun 19, 2024
2 of 3 checks passed
@farshidtz farshidtz deleted the IENG-1098-improve-versioning branch June 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve snap versioning
2 participants