Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replicated usage instructions #76

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Remove replicated usage instructions #76

merged 2 commits into from
Jun 24, 2024

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Jun 20, 2024 •
edited
Loading

@farshidtz farshidtz mentioned this pull request Jun 20, 2024
Merged
@farshidtz
Fix grammar
b8dcec6 
[skip ci]
@farshidtz farshidtz requested a review from locnnil June 21, 2024 08:52
locnnil
locnnil approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@locnnil locnnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note:
In a future PR that updates this README.md, it would be helpful to mention in the HW Compatibility section that this snap hasn't been tested on other SBCs, but it may / could work.

Overall, thank you, LGTM.

@locnnil locnnil marked this pull request as ready for review June 21, 2024 11:10
@farshidtz
Copy link
Member Author

In a future PR that updates this README.md, it would be helpful to mention in the HW Compatibility section that this snap hasn't been tested on other SBCs, but it may / could work.

Yes, with a bit of luck:

matter-pi-gpio-commander/snap/snapcraft.yaml

Lines 18 to 29 in 5f3a195

custom-gpio-dev:
interface: custom-device
custom-device: gpiochip
devices:
# Legacy Raspberry Pis
- /dev/gpiochip0
# Raspberry Pi 5
- /dev/gpiochip4
files:
read:
- /sys/devices/platform/soc/*.gpio/gpiochip0/dev
- /sys/devices/platform/axi/*.pcie/*.gpio/gpiochip4/dev

@locnnil locnnil merged commit 1750172 into main Jun 24, 2024
2 checks passed
@farshidtz farshidtz deleted the remove-doc-replications branch June 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locnnil locnnil locnnil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V1.1.0 Unable to determine board revision from /proc/cpuinfo README.md documentation is outdated for v2.0.0
2 participants
@farshidtz @locnnil