[gui] ask before closing running terminal #3835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have bidirectional streaming rpcs, but we usually send only one response back on that stream for most operations. therefore, the gui would only read data from the stream until it got the first reply. but this introduced errors in which the stream was disposed too early. now we read everything from the stream, so that issue shouldn't happen.
|
Was this designed? I am not used to terminals asking for confirmation to close, unless there are children processes running. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3835 +/- ##
==========================================
- Coverage 89.08% 89.07% -0.01%
==========================================
Files 254 254
Lines 14598 14598
==========================================
- Hits 13004 13003 -1
- Misses 1594 1595 +1 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
gui-open-shell-start-vm
branch
2 times, most recently
from
a9bd618 to
859eef1
Compare
levkropp
force-pushed
the
close-terminal-confirmation
branch
from
7fa0179 to
3a72a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a terminal is running, show a confirmation dialog that tells the user the state of the terminal will be lost.
MULTI-1682