fix: [DPE-7704] Local build fqdn for units #645
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taurus-forever
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
I am not sure how will it help to protect from bad DNS (better PR description may help here), but code is OK.
P.S. should scope=cluster be part of this PR?
Comment on lines
+32
to
+33
| """Return the Kubernetes domain.""" | ||
| return socket.getfqdn("kubernetes.default").split(".svc.")[-1] |
There was a problem hiding this comment.
why split on .svc.? is socket.getfqdn not give us the fqdn?
…ix/dpe7704-k8s-ha # Conflicts: # poetry.lock
Yes, as this not fully address the underlying issue as initially appeared. Right now I have some extra experimentation in my local branch, but need to carve some time to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #644
Fixes #633