-
Notifications
You must be signed in to change notification settings - Fork 16
Add extended attribute to get-cluster-status #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add extended attribute to get-cluster-status #428
Conversation
This changes from the default boolean that was being used internally to what mysql expects. The values between 0 and 3 are valid.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 66.39% 66.30% -0.09%
==========================================
Files 17 17
Lines 3169 3173 +4
Branches 419 420 +1
==========================================
Hits 2104 2104
- Misses 930 934 +4
Partials 135 135 ☔ View full report in Codecov by Sentry. |
7861989
to
89b6eb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arif-ali,
thank you for your contribution.
Please, check comments
89b6eb2
to
b7081c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution here!
@paulomach will we copy to K8s ourself or should we ask @arif-ali ?
we do it
b7081c4
to
27d86ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
👋🏻 Are these changes still desired? They got approved one year ago, despite Shayan's request to bump the lib version. |
Yeah, these would still be useful to have, I'm surprised even with the approvals it never got merged; and now we have conflicts |
I can probably help with that, this PR seems like a low hanging fruit everyone was onboard with. Although, if we are going to do it right, the same changes should be proposed both in K8s and VM substrates. |
27d86ed
to
43188b4
Compare
@arif-ali could you open a similar PR on mysql-k8s-operator repository? |
This changes from the default boolean that was being used internally to what mysql expects. The values between 0 and 3 are valid.
Issue
Would like to get extra cluster status attributes to debug issues with mysql replication.
Solution
The solution allows us to do this via actions, rather than logging in, and getting the data manually