[DPE-8050] Backup action cluster checks #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
added
the
enhancement
sinclert-canonical
force-pushed
the
sinclert/8050/backup-safety-checks
branch
2 times, most recently
from
f26cb28 to
a653ea0
Compare
sinclert-canonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
paulomach
reviewed
Sep 5, 2025
sinclert-canonical
force-pushed
the
sinclert/8050/backup-safety-checks
branch
from
a653ea0 to
24a435e
Compare
|
PR branch rebased from |
sinclert-canonical
requested review from
paulomach and
carlcsaposs-canonical
paulomach
reviewed
Sep 9, 2025
paulomach
approved these changes
Sep 9, 2025
delgod
reviewed
Sep 12, 2025
taurus-forever
approved these changes
Sep 12, 2025
sinclert-canonical
force-pushed
the
sinclert/8050/backup-safety-checks
branch
2 times, most recently
from
eab3ebc to
9b0f7c6
Compare
sinclert-canonical
force-pushed
the
sinclert/8050/backup-safety-checks
branch
from
9b0f7c6 to
68a3e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cluster health check to the
create-backupaction, which can be overridden using theforceparam.The MySQL cluster could be in any of the states listed in this documentation page. From those, only
OKandOK_PARTIALare considered safe, given that the rest of the states could introduce downtime (like the no-tolerance states) or data-loss (lost quorum, error, etc), when performing a backup.Additional changes
PropertyMockclass has been simplified.