Skip to content

Conversation

@sinclert-canonical
Copy link
Contributor

@sinclert-canonical sinclert-canonical commented Oct 15, 2025

This PR refactors the self-healing set of tests to Jubilant:

  • Network cut tests, porting existing ones from this file.
  • Process frozen tests, porting existing ones from this file.
  • Process killed tests, porting existing ones from this file.
  • Restart forceful tests, porting existing ones from this file.
  • Restart graceful tests, porting existing ones from this file.
  • Stop all tests, porting existing ones from this file.
  • Stop primary tests, porting existing ones from this file.

The new suffix added to the file name containing the ported integration tests has been added to improve diff visibility on GitHub. Will be removed right before merging.

@sinclert-canonical sinclert-canonical added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Oct 15, 2025
@sinclert-canonical sinclert-canonical force-pushed the sinclert/jubilant/self-healing-tests branch 11 times, most recently from 288533b to 5bd5137 Compare October 21, 2025 08:08
@sinclert-canonical sinclert-canonical force-pushed the sinclert/jubilant/self-healing-tests branch from f633518 to 7292f40 Compare October 21, 2025 15:29
@sinclert-canonical sinclert-canonical marked this pull request as ready for review October 21, 2025 15:44
Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can be done on next PR, but it seems there's no reason why execute_queries_on_unit is async and getting rid of it could free us of async on lot of places

@sinclert-canonical
Copy link
Contributor Author

It seems there's no reason why execute_queries_on_unit is async

True. This is something that Carl also commented in one of the previous Jubilant refactoring PRs.

I decided not to tweak it because changing such helper signature will trigger a tiny refactor scattered across all tests types, not only high-availability ones, and I would like to keep the set of refactors proposed during the last 2-3 weeks scoped to the high-availability ones. Follow-up PRs can refactor other tests, and potentially, simplify the referenced helper.

@sinclert-canonical sinclert-canonical force-pushed the sinclert/jubilant/self-healing-tests branch from f9b52a5 to 4a23d9a Compare October 23, 2025 14:18
@sinclert-canonical sinclert-canonical merged commit 8e565c7 into main Oct 23, 2025
243 of 250 checks passed
@sinclert-canonical sinclert-canonical deleted the sinclert/jubilant/self-healing-tests branch October 23, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants