-
Notifications
You must be signed in to change notification settings - Fork 18
[MISC] Self-healing Jubilant tests #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Self-healing Jubilant tests #694
Conversation
288533b to
5bd5137
Compare
f633518 to
7292f40
Compare
tests/integration/high_availability/high_availability_helpers_new.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Can be done on next PR, but it seems there's no reason why execute_queries_on_unit is async and getting rid of it could free us of async on lot of places
True. This is something that Carl also commented in one of the previous Jubilant refactoring PRs. I decided not to tweak it because changing such helper signature will trigger a tiny refactor scattered across all tests types, not only high-availability ones, and I would like to keep the set of refactors proposed during the last 2-3 weeks scoped to the high-availability ones. Follow-up PRs can refactor other tests, and potentially, simplify the referenced helper. |
f9b52a5 to
4a23d9a
Compare
This PR refactors the self-healing set of tests to Jubilant:
The
newsuffix added to the file name containing the ported integration tests has been added to improve diff visibility on GitHub. Will be removed right before merging.