Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor using data platform workflows #426

Merged
merged 11 commits into from
Feb 3, 2025

Conversation

misohu
Copy link
Member

@misohu misohu commented Jan 30, 2025

Closes: #421 and #423

  1. Refactors the charmcraft.yaml files to use st124 shorthand notation and python plugin instead of charm plugin for compatibility with charmcraftcache
  2. Replaces the integrate.yaml and on_pull_request.yaml workflows into ci.yaml, a workflow that does the following:
  • Gets the paths for the charms in the multi-charm repo
  • Builds each charm in a separate runner with charmcraftcache
  • Passes the built charm artifacts to test jobs
  • Runs the individual integration tests for each charm
  • Runs the bundle integration tests
  • Publishes the built charms to <track>/edge/pr-xx channel
  1. Similarly, replaces on_push.yaml with release.yaml workflow, which:
  • Re-uses ci.yaml to run the builds, checks, and tests
  • Published the built charms to <track>/edge only if the tests pass
  1. Renames the old release.yaml to promote.yaml
  2. Refactors the integration test .py files to deploy from the pre-built charms, and keeps the option for local builds

…ation (#424)

* Use python plugin and add licenses to charms, use charmcraft channel 3.x/edge, use branch for quality checks workflow with charmcraft 3.x/edge
@misohu misohu marked this pull request as ready for review January 31, 2025 10:13
@misohu misohu changed the title Kf 6217 use cache builds dev branch ci: refactor using data platform workflows Jan 31, 2025
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @misohu, a few comments

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/promote.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny final comments

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @misohu ! Once you merge could you also send a PR to https://github.com/canonical/charmcraftcache-hub to point the branch to main? See for example canonical/charmcraftcache-hub#291

@misohu misohu merged commit fd6a70b into main Feb 3, 2025
24 checks passed
@misohu misohu deleted the KF-6217-use-cache-builds-dev-branch branch February 3, 2025 13:59
carlcsaposs-canonical pushed a commit to canonical/charmcraftcache-hub that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the CI to use to data platform workflows for building charms
2 participants