-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: refactor using data platform workflows #426
Conversation
…ation (#424) * Use python plugin and add licenses to charms, use charmcraft channel 3.x/edge, use branch for quality checks workflow with charmcraft 3.x/edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @misohu, a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny final comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx @misohu ! Once you merge could you also send a PR to https://github.com/canonical/charmcraftcache-hub to point the branch to main
? See for example canonical/charmcraftcache-hub#291
Pointing to main now that canonical/notebook-operators#426 is merged
Closes: #421 and #423
charmcraft.yaml
files to usest124
shorthand notation andpython
plugin instead ofcharm
plugin for compatibility withcharmcraftcache
charmcraftcache
<track>/edge/pr-xx
channel<track>/edge
only if the tests passrelease.yaml
topromote.yaml