Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly set working-dir for workload in charm.py #128

Merged
merged 2 commits into from
Jan 19, 2024
Merged

explicitly set working-dir for workload in charm.py #128

merged 2 commits into from
Jan 19, 2024

Conversation

ca-scribner
Copy link
Contributor

This adds a working-dir argument for the oidc-authservice pebble plan. This is required to allow a rock of the upstream image to be drop-in replacement.

This also may fix #126, although I don't understand why this would be the cause of that issue.

@ca-scribner ca-scribner marked this pull request as ready for review January 19, 2024 16:21
@ca-scribner ca-scribner requested a review from a team as a code owner January 19, 2024 16:21
@ca-scribner ca-scribner enabled auto-merge (squash) January 19, 2024 16:22
ca-scribner
ca-scribner commented Jan 19, 2024
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
orfeas-k
orfeas-k reviewed Jan 19, 2024
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
@ca-scribner ca-scribner merged commit f97ecf8 into main Jan 19, 2024
7 checks passed
@ca-scribner ca-scribner deleted the KF-5202-fix-oidc-service-working-dir branch January 19, 2024 16:27
@ca-scribner ca-scribner mentioned this pull request Jan 19, 2024
Closed
@orfeas-k orfeas-k mentioned this pull request Jan 19, 2024
Closed
ca-scribner added a commit that referenced this pull request Jan 29, 2024
@ca-scribner
explicitly set workingdir for workload in charm.py (#128)
cce16a6
kimwnasptd pushed a commit that referenced this pull request Jan 29, 2024
@ca-scribner
cherry pick rock, workingdir fix to main (#133)
3d761e7 
* explicitly set workingdir for workload in charm.py (#128)

* use rock for oidc-authservice on `main` for ckf-1.8 (#132)

Closes #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oidc charm fails to replan after config public-url
2 participants
@ca-scribner @orfeas-k