Skip to content

Commit

Permalink
clean up comments, ready for review
Browse files Browse the repository at this point in the history
  • Loading branch information
barrettj12 committed Jun 30, 2023
1 parent 75bfeeb commit 062524e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions internals/plan/plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -523,8 +523,6 @@ func (t *LogTarget) Merge(other *LogTarget) {
if other.Location != "" {
t.Location = other.Location
}
// TODO: reduce log targets?
// e.g. [..., all, -svc1] -> [all, -svc1]
t.Services = append(t.Services, other.Services...)
}

Expand Down Expand Up @@ -774,6 +772,7 @@ func CombineLayers(layers ...*Layer) (*Layer, error) {
if _, ok := combined.Services[serviceName]; ok {
continue
}
// Check if this is `-svc`
serviceName = strings.TrimPrefix(serviceName, "-")
if _, ok := combined.Services[serviceName]; ok {
continue
Expand Down

0 comments on commit 062524e

Please sign in to comment.