obtain lock before reading ServiceManager.services

canonical · Aug 15, 2023 · 8863487 · 8863487
1 parent 97c4681
commit 8863487
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/internals/overlord/servstate/handlers.go b/internals/overlord/servstate/handlers.go
@@ -280,7 +280,11 @@ func (m *ServiceManager) serviceForStop(task *state.Task, name string) *serviceD
 func (m *ServiceManager) removeService(name string) {
 	m.servicesLock.Lock()
 	defer m.servicesLock.Unlock()
+	m.removeServiceInternal(name)
+}
 
+// not concurrency-safe, please lock m.servicesLock before calling
+func (m *ServiceManager) removeServiceInternal(name string) {
 	svc, svcExists := m.services[name]
 	if !svcExists {
 		return

diff --git a/internals/overlord/servstate/manager.go b/internals/overlord/servstate/manager.go
@@ -88,8 +88,12 @@ func (m *ServiceManager) Stop() {
 	if err != nil {
 		logger.Noticef("Cannot stop child process reaper: %v", err)
 	}
+
+	// Close all the service ringbuffers
+	m.servicesLock.Lock()
+	defer m.servicesLock.Unlock()
 	for name := range m.services {
-		m.removeService(name)
+		m.removeServiceInternal(name)
 	}
 }