Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "context" option for pebble exec and exec health checks #159

Closed
benhoyt opened this issue Oct 18, 2022 · 1 comment
Closed

Add "context" option for pebble exec and exec health checks #159

benhoyt opened this issue Oct 18, 2022 · 1 comment

Comments

@benhoyt
Copy link
Contributor

benhoyt commented Oct 18, 2022

Per discussion with Gustavo at our spec meeting last night, we'd like to add an API parameter context to pebble exec (command line arg --context) and to exec-type health checks, which would be the name of the service whose context to run the command in. It would use all the relevant context from the service definition, specifically environment variables and user and group.

Once we add working-dir we'll include that in the context too.

Note that we'd also like a way to say "inherit the context / env vars from pebble itself". We could do that with --context=- or --context=pebble or even --context= (empty string). We didn't come to a final decision on that syntax though.

Spec OP034.

@benhoyt
Copy link
Contributor Author

benhoyt commented Jul 12, 2023

Done in #246, though we decided to spell it "service-context".

@benhoyt benhoyt closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant