Add support for services to configure working directory #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes canonical#158 (in preparation for canonical#159)
barrettj12
requested changes
Jun 26, 2023
niemeyer
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Looks good, thanks!
Not merging waiting for the point you mention in @barrettj12's review.
benhoyt
changed the title
jujubot
added a commit
to juju/juju
that referenced
this pull request
Jul 12, 2023
#15909 Relevant changes for use of Pebble in Juju: * fix: exec and checks inherit environment from daemon (canonical/pebble#234) * Allow non-root to specify user/group to itself (canonical/pebble#239) * Add support for services to configure working directory (canonical/pebble#245) * Improve error messages with exec, especially if working dir missing (canonical/pebble#236) * Add "service context" support for exec and health checks (canonical/pebble#246) Full list of changes [here](canonical/pebble@5842ea6...00bcd1f). Note that this updates the version of `canonical/x-go` as well as switching to Canonical fork of `go-flags`.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158 (in preparation for #159)