daemon: add ability to use syscall based reboot #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
reviewed
Jun 29, 2023
benhoyt
approved these changes
Jul 3, 2023
flotter
force-pushed
the
syscall-reboot
branch
3 times, most recently
from
0d39fb2
to
0fddb08
Compare
benhoyt
approved these changes
Jul 3, 2023
niemeyer
requested changes
Jul 3, 2023
anpep
suggested changes
Jul 3, 2023
Reboot in the daemon is currently relying on userspace having a shutdown command. This may not always be the case, as Pebble is used in a wide variety of environments. Add a SetSyscallReboot() function to the daemon to allow the daemon to be initialised with a syscall based reboot implementation.
benhoyt
reviewed
Jul 6, 2023
anpep
approved these changes
Jul 11, 2023
anpep
approved these changes
Aug 2, 2023
flotter
force-pushed
the
syscall-reboot
branch
from
f3d15ca
to
d629398
Compare
flotter
commented
Aug 10, 2023
niemeyer
approved these changes
Aug 10, 2023
flotter
force-pushed
the
syscall-reboot
branch
from
34430d6
to
ec93b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot in the daemon is currently relying on userspace having a shutdown command. This may not always be the case, as Pebble is used in a wide variety of environments.
Add a SetRebootMode() function to the daemon to allow the daemon to be initialised with a syscall based reboot implementation. The default reboot mode using systemd remains unchanged.