Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-3777] Multiplex services to log targets using only a log-target.services field #252

Merged
merged 14 commits into from
Jul 3, 2023
Merged

[JUJU-3777] Multiplex services to log targets using only a log-target.services field #252

merged 14 commits into from
Jul 3, 2023

Commits on Jun 29, 2023

  1. add log forwarding section to README

    @barrettj12
    barrettj12 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    67e0504 View commit details
    Browse the repository at this point in the history

  2. remove LogTargets field from service

    @barrettj12
    barrettj12 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    ea6f533 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. remove Selection field from LogTarget

    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    9c5c5b0 View commit details
    Browse the repository at this point in the history

  2. add Services field to LogTarget

    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    0504a05 View commit details
    Browse the repository at this point in the history

  3. validate LogTargets.Services

    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    f2d72dd View commit details
    Browse the repository at this point in the history

  4. add "services" field to plan tests 

    - fix service name validation to handle `-`
    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    c13a51b View commit details
    Browse the repository at this point in the history

  5. add deprecated service names

    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    1f6b175 View commit details
    Browse the repository at this point in the history

  6. write LogsTo test 

    - catch iteration mistake in LogsTo
- modify plan override test, to test changing location/type
    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    75bfeeb View commit details
    Browse the repository at this point in the history

  7. clean up comments, ready for review

    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    062524e View commit details
    Browse the repository at this point in the history

  8. elaborate on README example (thx @benhoyt) 

    Co-authored-by: Ben Hoyt <[email protected]>
    @barrettj12 @benhoyt
    barrettj12 and benhoyt authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    439165f View commit details
    Browse the repository at this point in the history

  9. disallow services starting with "-" 

    - consolidate svc / -svc validation in CombineLayers
    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    1d97914 View commit details
    Browse the repository at this point in the history

  10. fix logger import order

    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    bc85a35 View commit details
    Browse the repository at this point in the history

  11. target.Location must always be set

    @barrettj12
    barrettj12 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    8901224 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. address @niemeyer's review comments 

    - simplify log-target.services validation
- improve deprecation warning
- expand examples in README
    @barrettj12
    barrettj12 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    576706f View commit details
    Browse the repository at this point in the history