Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce import order #254

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Enforce import order #254

merged 4 commits into from
Jul 31, 2023
+275 −206

Commits on Jul 5, 2023

  1. Fix import order 

    All Go files should have exactly three import groups:
- stdlib
- 3rd-party / non-project imports
- project imports (from inside canonical/pebble)
    @barrettj12
    barrettj12 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a4b9c88 View commit details
    Browse the repository at this point in the history

  2. Fix daemon_test.go imports 

    gocheck should be imported with `.`, as suggested in the comment.
    @barrettj12
    barrettj12 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    fe5189a View commit details
    Browse the repository at this point in the history

  3. Add docs about import order to HACKING.md

    @barrettj12
    barrettj12 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    491b694 View commit details
    Browse the repository at this point in the history

  4. Enforce import order using gci 

    Add linting to the pre-merge checks to enforce Go import groups:
- stdlib
- 3rd-party / non-Pebble imports
- Pebble imports
    @barrettj12
    barrettj12 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bd46b08 View commit details
    Browse the repository at this point in the history