Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logfwd): log forwarding implementation II #256

Merged
merged 31 commits into from
Aug 22, 2023
Merged

feat(logfwd): log forwarding implementation II #256

merged 31 commits into from
Aug 22, 2023

Commits on Aug 2, 2023

  1. Log forwarding implementation

    @barrettj12
    barrettj12 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ff53051 View commit details
    Browse the repository at this point in the history

  2. remove extra fakeLogManager decl

    @barrettj12
    barrettj12 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    760e7a4 View commit details
    Browse the repository at this point in the history

  3. surface client errors 

    Errors from the gatherer tomb are not being surfaced to the user, as there is
nothing checking tomb.Err().
Additionally, a write/flush failure should not bring down the gatherer - it
could be e.g. a temporary outage.
Better to log the failures rather than exiting the main loop.
    @barrettj12
    barrettj12 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6e03c0c View commit details
    Browse the repository at this point in the history

  4. fix imports in gatherer.go

    @barrettj12
    barrettj12 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5ca3752 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. fix a small typo in comment

    @barrettj12
    barrettj12 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e91f756 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Move plan logic out of pullerGroup

    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    2f1d967 View commit details
    Browse the repository at this point in the history

  2. Add extra ctx.Done check in logPuller.loop

    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    ab40a6c View commit details
    Browse the repository at this point in the history

  3. Uppercase logGatherer methods (PlanChanged, ServiceStarted, Stop) whi… 

    …ch are intended for use by other types
    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    7e4d212 View commit details
    Browse the repository at this point in the history

  4. fix error/log messages

    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b03882b View commit details
    Browse the repository at this point in the history

  5. Revert changes to state engine

    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    783c3ca View commit details
    Browse the repository at this point in the history

  6. Stop log manager after service manager 

    - close ringbuffer on service stop
- add some more debug logging
    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    baabeb2 View commit details
    Browse the repository at this point in the history

  7. kill gatherer tomb with nil 

    - catch and log error from tomb.Wait()
    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    04a3354 View commit details
    Browse the repository at this point in the history

  8. make some channels read/write only

    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b35a8b0 View commit details
    Browse the repository at this point in the history

  9. pullerGroup.Add: log warning if puller already exists 

    - add comment about when puller.loop exits
    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b31e4be View commit details
    Browse the repository at this point in the history

  10. rename logPuller.kill to cancel 

    - extra comment for gatherer final flush ctx
    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    01bd92a View commit details
    Browse the repository at this point in the history

  11. flesh out logGatherer.PlanChanged doc comment

    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    ab46d31 View commit details
    Browse the repository at this point in the history

  12. use timer instead of ticker

    @barrettj12
    barrettj12 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6bae051 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. rewrite pullerGroup using tombs

    @barrettj12
    barrettj12 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    be25405 View commit details
    Browse the repository at this point in the history

  2. close service ring buffers on Pebble shutdown

    @barrettj12
    barrettj12 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    04de335 View commit details
    Browse the repository at this point in the history

  3. fix imports

    @barrettj12
    barrettj12 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b39c6d0 View commit details
    Browse the repository at this point in the history

  4. small comment fix in overlord

    @barrettj12
    barrettj12 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5899532 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Improve handling of log gatherer tear down.

    @hpidcock
    hpidcock committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    2b4f8eb View commit details
    Browse the repository at this point in the history

  2. add persistent goroutine to pullerGroup tomb 

    This avoids runtime panic from calling Go after all goroutines have returned.

Also, we need to kill the pullerGroup tomb in Stop() to tell the pullerGroup
that it's time to shut down.
    @barrettj12
    barrettj12 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    97e7d94 View commit details
    Browse the repository at this point in the history

  3. rename tickPeriod to bufferTimeout

    @barrettj12
    barrettj12 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9465a3a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. address Ben's review comments

    @barrettj12
    barrettj12 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5e77fb3 View commit details
    Browse the repository at this point in the history

  2. lowercase pullerGroup contains and len methods

    @barrettj12
    barrettj12 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    28d2d51 View commit details
    Browse the repository at this point in the history

  3. remove fake client implementations

    @barrettj12
    barrettj12 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    0b0d873 View commit details
    Browse the repository at this point in the history

  4. add comment on pullerGroup tomb

    @barrettj12
    barrettj12 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    97c4681 View commit details
    Browse the repository at this point in the history

  5. obtain lock before reading ServiceManager.services

    @barrettj12
    barrettj12 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8863487 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Add some more doc comments to pullerGroup methods

    @barrettj12
    barrettj12 committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c0584ce View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Remove internal error on tomb.Wait log

    @benhoyt
    benhoyt authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3c92f43 View commit details
    Browse the repository at this point in the history