-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(servstate): use WaitDelay to avoid Command.Wait blocking on stdin/out/err #275
Merged
Commits on Aug 15, 2023
-
Use Command.WaitDelay to avoid Command.Wait blocking on stdin/out/err
Add WaitDelay to ensure cmd.Wait() returns in a reasonable timeframe if the goroutines that cmd.Start() uses to copy Stdin/Stdout/Stderr are blocked when copying due to a sub-subprocess holding onto them. Read more details in these issues: - golang/go#23019 - golang/go#50436 This isn't the original intent of kill-delay, but it seems reasonable to reuse it in this context. Fixes canonical#149
Configuration menu - View commit details
-
Copy full SHA for 10fa2a4 - Browse repository at this point
Copy the full SHA 10fa2a4View commit details -
Use WaitDelay in exec and exec checks too, for good measure
It's unlikely to be needed here, but it won't hurt either. Use a smaller timeout (1s) as these are intended for short-running commands.
Configuration menu - View commit details
-
Copy full SHA for 77af02a - Browse repository at this point
Copy the full SHA 77af02aView commit details -
Canonicalize some log messages
Our style is to start with an uppercase letter (for logs, not errors) and to use "Cannot X" rather than "Error Xing".
Configuration menu - View commit details
-
Copy full SHA for e3ed6a1 - Browse repository at this point
Copy the full SHA e3ed6a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a256ee8 - Browse repository at this point
Copy the full SHA a256ee8View commit details
Commits on Aug 16, 2023
-
Add test for service manager WaitDelay
Also factor out setupEmptyServiceManager as the same code is used in 7 places.
Configuration menu - View commit details
-
Copy full SHA for f000cc7 - Browse repository at this point
Copy the full SHA f000cc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d37f5d - Browse repository at this point
Copy the full SHA 2d37f5dView commit details
Commits on Aug 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a1e328a - Browse repository at this point
Copy the full SHA a1e328aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1be67fc - Browse repository at this point
Copy the full SHA 1be67fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for faf1a9b - Browse repository at this point
Copy the full SHA faf1a9bView commit details
Commits on Aug 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da59527 - Browse repository at this point
Copy the full SHA da59527View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.