test(testutil): fix tests when run with -count=2 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when you run:
go test -count=2 -v ./internals/testutil/ -check.v
It fails with the following error:
FAIL: exec_test.go:89: fakeCommandSuite.TestFakeShellchecksWhenAvailable
using shellcheck: "/usr/bin/shellcheck"
exec_test.go:106:
c.Assert(fakeShellcheck.Calls(), check.DeepEquals, [][]string{
{"shellcheck", "-s", "bash", "-"},
})
... obtained [][]string = [][]string(nil)
... expected [][]string = [][]string{[]string{"shellcheck", "-s", "bash", "-"}}
... Difference:
... [][]string[0] != [][]string[1]
Because TestFakeShellchecksWhenAvailable relies on global state. Reset
this global state before each run to allow this package's tests to be
run more than once (-count=N where N>1).
benhoyt
changed the title
benhoyt
changed the title
anpep
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you run:
It fails with the following error:
Because TestFakeShellchecksWhenAvailable relies on global state. Reset this global state before each run to allow this package's tests to be run more than once (-count=N where N>1).