feat(client): Export DoSync/DoAsync and RequestInfo.
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is required to truly make the Client API changes in #285 usable from a client extension implementation. This is currently in draft form, mainly to capture some proposals on how to best do this. |
benhoyt
approved these changes
Aug 28, 2023
benhoyt
approved these changes
Aug 28, 2023
hpidcock
approved these changes
Aug 28, 2023
@hpidcock That's fair. I'd be fine with |
|
Closing this because it's basically exposing an implementation detail from the Pebble client that might not be suitable for other clients. Will iterate on a new proposal soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch exports
client.Do{Sync,Async}methods and moves the arguments to aRequestInfostruct. The idea is that applications extending Pebble can call these helper methods in order to perform HTTP requests to the daemon through an extended client (see #285).