feat(daemon): daemon access for API extensions #293
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following PR provided Pebble derived projects to extend the supplied daemon HTTP API handlers. canonical#265 However, currently such a handler cannot access the daemon, even though we added a daemon method to also expose the Overlord. func v1PostDevice( *daemon.Command, req *http.Request, _ *daemon.UserState) daemon.Response { : // Cannot access c.d (daemon is private) ovld := c.d.Overlord() : } This PR adds c.Daemon() to allow access inside externally defined HTTP API handlers.
|
I think this was most likely just an oversight at the time, but please let me know if I am missing something obvious where. |
benhoyt
approved these changes
Aug 31, 2023
niemeyer
approved these changes
Aug 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR provided Pebble derived projects to extend the supplied daemon HTTP API handlers.
#265
However, currently such a handler cannot access the daemon, even though we added a daemon method to also expose the Overlord.
This PR adds c.Daemon() to allow access inside externally defined HTTP API handlers.