Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(state): avoid need for state lock in LatestWarningTime #493

Merged
merged 2 commits into from
Aug 29, 2024
Merged

refactor(state): avoid need for state lock in LatestWarningTime #493

merged 2 commits into from
Aug 29, 2024

Commits on Aug 27, 2024

  1. refactor(state): avoid need for state lock in LatestWarningTime 

    This means that not every request/response needs to acquire the state
lock, as shown by the removal of the custom response type in the
/v1/health endpoint.

Note that there's a test, TestHealthStateLockNotHeldSuccess, that
specifically tests that the state lock is not held during /v1/health
requests. If we accidentally introduce locking again, that will fail.
    @benhoyt
    benhoyt committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2c6660d View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Tweak var declaration style

    @benhoyt
    benhoyt committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6a9f27b View commit details
    Browse the repository at this point in the history