Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the intro to ebpf page #131

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

network-charles
Copy link
Contributor

@network-charles network-charles commented Feb 3, 2025

  • I added a language for the texts wrapped into a CodeFence.

Relevant to canonical/open-documentation-academy#162

Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to help make the Server docs better :) greater consistency in how the languages are defined in code blocks was a previously filed (and closed) issue, so thanks for finding these additional ones that were missed.

I do have two other comments, but once those are addressed I will be happy to merge these changes.

explanation/intro-to/ebpf.md Outdated Show resolved Hide resolved
explanation/intro-to/ebpf.md Outdated Show resolved Hide resolved
@network-charles network-charles force-pushed the network-charles-patch-1 branch from fe63778 to a071fb9 Compare February 4, 2025 15:21
Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :) thanks for making the suggested changes, and for continuing to help us make the Server docs better

@s-makin s-makin merged commit ffce884 into canonical:main Feb 4, 2025
1 check passed
@network-charles network-charles deleted the network-charles-patch-1 branch February 4, 2025 17:18
@network-charles network-charles changed the title Improve the intro to ebf page Improve the intro to ebpf page Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants