-
Notifications
You must be signed in to change notification settings - Fork 220
Bug fixes, send/receive debug logs and Unsigned 24 support #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TzviRonen
wants to merge
11
commits into
canopen-python:master
Choose a base branch
from
TzviRonen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5141b19
test if callback exist before removing it
TzviRonen 3ce8ab4
Added send message debug log
TzviRonen bc06df4
Added debug logs and pause before read
TzviRonen 3fb146e
fixed get_data var len calc
TzviRonen 659899d
Added Unsigned24 data type
TzviRonen 9b9efb7
Added PyCharm to gitignore
TzviRonen a8fcd87
request_response RETRY_DELAY
TzviRonen d0d9bba
made RETRY_DELAY default zero
TzviRonen b14f43e
removed callback test
TzviRonen 56b206a
fixed uint24 support comments
TzviRonen a108eee
t
TzviRonen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| __pycache__/ | ||
| *.py[cod] | ||
| *$py.class | ||
| .idea/ | ||
|
|
||
| # C extensions | ||
| *.so | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a separate section for IDE stuff down below, if such things must be collected here.
This change seems unrelated though, so let's keep it in a separate commit / PR.