feat: support for App Open Ad en Android e iOS #386

BETOXL · 2025-10-11T02:17:34Z

Adds native and TypeScript support for the Open Ad App format on Android and iOS.
Includes usage examples in the Angular demo.
Documentation and exposed events.

Copilot

Pull Request Overview

This PR adds support for App Open Ad format on both Android and iOS platforms, integrating it into the AdMob plugin with complete TypeScript definitions and usage examples.

Adds App Open Ad functionality with load, show, and status check methods
Implements native iOS and Android code using Google Mobile Ads SDK
Includes TypeScript definitions, events, and Angular demo integration

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/web.ts	Adds stub methods for App Open Ad functionality in web implementation
src/index.ts	Exports new App Open Ad module
src/definitions.ts	Integrates App Open Ad plugin interface into main plugin definitions
src/app-open/*	Complete TypeScript definitions for App Open Ad functionality including options, events, and plugin interface
ios/Sources/AdMobPlugin/*	Native iOS implementation using GADAppOpenAd with manager pattern
android/src/main/java/*	Native Android implementation using Google Mobile Ads AppOpenAd API
demo/angular/src/app/app.component.ts	Angular demo showing App Open Ad usage with event listeners
README.md	Documentation for App Open Ad API methods and usage examples

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/web.ts

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

demo/angular/src/app/app.component.ts

README.md

distante

Hello @BETOXL ! thanks for your PR, please check the comments and the CI. You probably need to run the formatter. (I will try to add it to the pre commit lint in the future)

Also can you please update the tests to include your changes?

Thank you!

package-lock.json

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

demo/angular/src/app/app.component.ts

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

src/app-open/app-open-definitions.interface.ts

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

src/web.ts

distante · 2025-10-11T09:17:01Z

README.md

+} from '@capacitor-community/admob';
+
+export async function showAppOpenAd(): Promise<void> {
+  // Escuchar eventos


Comments in English.

Co-authored-by: Copilot <[email protected]>

distante · 2025-10-14T10:01:07Z

a lot of comments are not correctly resolved.

distante

Please do not resolve comments without fixing them.

no single line ifs please

this should be inside the AdMob class.

comments in English.

no single line ifs please

comments in English

Replace any type with proper AppOpenAdOptions type for better type safety and API consistency.

distante

The CI is still failing.

You should check how the other implementation is done so you can fix and add your tests.

src/web.ts

android/src/main/java/com/getcapacitor/community/admob/AdMob.java

Moved AppOpenAd Plugin initialization inside the AdMob class.

delete comment

BETOXL

delete comment

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdManager.java

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

src/app-open/app-open-definitions.interface.ts

src/web.ts

test appOpen

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 17 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/com/getcapacitor/community/admob/appopen/AppOpenAdPlugin.java

Copilot · 2025-12-04T07:01:49Z

ios/Sources/AdMobPlugin/AppOpen/AppOpenAdManager.swift

+extension AppOpenAdManager: GADFullScreenContentDelegate {
+    public func adDidDismissFullScreenContent(_ ad: GADFullScreenPresentingAd) {
+        appOpenAd = nil
+        isShowingAd = false
+        onClosed?()
+    }
+
+    public func ad(_ ad: GADFullScreenPresentingAd, didFailToPresentFullScreenContentWithError error: Error) {
+        appOpenAd = nil
+        isShowingAd = false
+        onFailedToShow?()
+    }
+}


The iOS implementation is missing the adWillPresentFullScreenContent delegate method to emit the appOpenAdOpened event.

Looking at other ad implementations (e.g., AdInterstitialExecutor.swift), when an ad is presented, the delegate method adWillPresentFullScreenContent is called and should notify listeners with the corresponding event.

Add the following method to the extension:

public func adWillPresentFullScreenContent(_ ad: GADFullScreenPresentingAd) { onOpened?() }

And store the onOpened callback similar to how onClosed and onFailedToShow are stored.

Copilot · 2025-12-04T07:01:49Z

README.md

+loadAppOpen(options: AppOpenAdOptions) => Promise<void>
+```
+
+Carga un anuncio App Open


Documentation for the App Open Ad methods is written in Spanish ("Carga un anuncio App Open", "Muestra el anuncio App Open si está cargado", "Verifica si el anuncio App Open está cargado", "Agrega listeners para eventos de App Open").

The rest of the README is in English, so these should be translated for consistency. For example:

Line 1120: "Load an App Open ad"

Line 1135: "Shows the App Open ad if loaded"

Line 1146: "Check if the App Open ad is loaded"

Line 1159: "Add listeners for App Open events"

README.md

demo/angular/src/app/app.component.ts

src/web.ts

Copilot · 2025-12-04T07:01:52Z

android/src/test/java/com/getcapacitor/community/admob/models/AdOptionsTest.java

+        public void appOpen_ad_Id() {
+            final String expected = "Some Given AppOpen Test Id";
+            when(pluginCallMock.getString(eq("adId"), anyString())).thenReturn(expected);
+
+            final AdOptions adOptions = AdOptions.getFactory().createAppOpenOptions(pluginCallMock);
+
+            assertEquals(expected, adOptions.adId);
+        }
+
+        @Test
+        public void appOpen_position() {
+            final String wantedProperty = "position";
+            final String expected = "TOP_CENTER";
+            final String defaultValue = "BOTTOM_CENTER";
+            when(pluginCallMock.getString(eq(wantedProperty), anyString())).thenReturn(expected);
+
+            final AdOptions adOptions = AdOptions.getFactory().createAppOpenOptions(pluginCallMock);
+
+            verify(pluginCallMock).getString(wantedProperty, defaultValue);
+            assertEquals(expected, adOptions.position);
+        }
+
+        @Test
+        public void appOpen_margin() {
+            final String wantedProperty = "margin";
+            final int expected = 10;
+            final int defaultValue = 0;
+            when(pluginCallMock.getInt(eq(wantedProperty), anyInt())).thenReturn(expected);
+
+            final AdOptions adOptions = AdOptions.getFactory().createAppOpenOptions(pluginCallMock);
+
+            verify(pluginCallMock).getInt(wantedProperty, defaultValue);
+            assertEquals(expected, adOptions.margin);
+        }
+
+        @Test
+        public void appOpen_isTesting() {
+            final String wantedProperty = "isTesting";
+            final boolean expected = true;
+            final boolean defaultValue = false;
+            when(pluginCallMock.getBoolean(eq(wantedProperty), anyBoolean())).thenReturn(expected);
+
+            final AdOptions adOptions = AdOptions.getFactory().createAppOpenOptions(pluginCallMock);
+
+            verify(pluginCallMock).getBoolean(wantedProperty, defaultValue);
+            assertEquals(expected, adOptions.isTesting);
+        }
+
+        @Test
+        public void appOpen_npa() {
+            final String wantedProperty = "npa";
+            final boolean expected = true;
+            final boolean defaultValue = false;
+            lenient().when(pluginCallMock.getBoolean(eq(wantedProperty), anyBoolean())).thenReturn(expected);
+
+            final AdOptions adOptions = AdOptions.getFactory().createAppOpenOptions(pluginCallMock);
+
+            verify(pluginCallMock).getBoolean(wantedProperty, defaultValue);
+            assertEquals(expected, adOptions.npa);
+        }
+
+        @Test
+        public void appOpen_ssv() {
+            final String customData = "customData";
+            final String userId = "userId";
+            final String wantedProperty = "ssv";
+            final JSObject expected = new JSObject();
+            expected.put(customData, customData);
+            expected.put(userId, userId);
+            lenient().when(pluginCallMock.getObject(eq(wantedProperty))).thenReturn(expected);
+
+            final AdOptions adOptions = AdOptions.getFactory().createAppOpenOptions(pluginCallMock);
+
            verify(pluginCallMock, atLeastOnce()).getObject(wantedProperty);
            assertEquals(userId, adOptions.ssvInfo.getUserId());
            assertEquals(customData, adOptions.ssvInfo.getCustomData());


The tests reference a createAppOpenOptions method on AdOptions.getFactory(), but this method doesn't exist in the AdOptionsFactory class.

Looking at the factory pattern in AdOptions.java, you need to add a createAppOpenOptions method to the AdOptionsFactory class, similar to createBannerOptions, createInterstitialOptions, etc. The method should return an AdOptions instance with an appropriate testing ID for App Open ads.

README.md

demo/angular/src/app/app.component.ts

…/AppOpenAdPlugin.java Co-authored-by: Copilot <[email protected]>

Co-authored-by: Copilot <[email protected]>

feat: soporte para App Open Ad en Android e iOS

e3c2d24

distante requested a review from Copilot October 11, 2025 09:03

Copilot AI reviewed Oct 11, 2025

View reviewed changes

distante requested changes Oct 11, 2025

View reviewed changes

BETOXL and others added 5 commits October 13, 2025 12:00

Update src/web.ts

ded6452

Co-authored-by: Copilot <[email protected]>

Update src/web.ts

d1bbba1

Co-authored-by: Copilot <[email protected]>

Update demo/angular/src/app/app.component.ts

9494d2e

Co-authored-by: Copilot <[email protected]>

Update README.md

e65274f

Co-authored-by: Copilot <[email protected]>

Merge branch 'master' into feat/app-open-ad

8d6d787

BETOXL requested a review from distante October 13, 2025 21:53

distante requested changes Oct 14, 2025

View reviewed changes

BETOXL added 11 commits October 14, 2025 12:09

Update README.md

a1d73cf

Update README.md

2549a0a

Update AppOpenAdManager.java

8f33ad7

Update AppOpenAdManager.java

4aac09b

Update AppOpenAdManager.java

23ab476

no single line ifs please

Update AdMob.java

eee34de

this should be inside the AdMob class.

Update app.component.ts

5359b16

comments in English.

Update AppOpenAdManager.swift

3548d4f

no single line ifs please

Update app-open-definitions.interface.ts

a00d292

comments in English

Update web.ts

f81c2d6

Replace any type with proper AppOpenAdOptions type for better type safety and API consistency.

Update README.md

a0eae03

distante reviewed Oct 15, 2025

View reviewed changes

src/web.ts Outdated Show resolved Hide resolved

android/src/main/java/com/getcapacitor/community/admob/AdMob.java Outdated Show resolved Hide resolved

BETOXL added 2 commits October 25, 2025 16:43

Refactor AppOpenAd Plugin initialization

b82471b

Moved AppOpenAd Plugin initialization inside the AdMob class.

Define AppOpenAdOptions interface and update loadAppOpen

f742340

delete comment

BETOXL commented Oct 25, 2025

View reviewed changes

BETOXL changed the title ~~feat: soporte para App Open Ad en Android e iOS~~ feat: support for App Open Ad en Android e iOS Oct 25, 2025

BETOXL added 2 commits October 25, 2025 16:53

Merge branch 'main' into feat/app-open-ad

a885fad

Update AppOpenAdManager.java

3b9d047

test appOpen

BETOXL mentioned this pull request Dec 4, 2025

App open ad unit is now needed more then ever #338

Open

distante requested a review from Copilot December 4, 2025 06:55

Copilot started reviewing on behalf of distante December 4, 2025 06:55 View session

Copilot finished reviewing on behalf of distante December 4, 2025 06:59

Copilot AI reviewed Dec 4, 2025

View reviewed changes

BETOXL and others added 7 commits December 4, 2025 10:04

Update android/src/main/java/com/getcapacitor/community/admob/appopen…

5b3f914

…/AppOpenAdPlugin.java Co-authored-by: Copilot <[email protected]>

Update src/web.ts

ed1c654

Co-authored-by: Copilot <[email protected]>

Update README.md

5fcb155

Co-authored-by: Copilot <[email protected]>

Update demo/angular/src/app/app.component.ts

88caf87

Co-authored-by: Copilot <[email protected]>

Update README.md

ef80ce7

Co-authored-by: Copilot <[email protected]>

Update README.md

9d8c31b

Co-authored-by: Copilot <[email protected]>

Update demo/angular/src/app/app.component.ts

7c8c244

Co-authored-by: Copilot <[email protected]>

feat: support for App Open Ad en Android e iOS #386

Are you sure you want to change the base?

feat: support for App Open Ad en Android e iOS #386

Uh oh!

Conversation

BETOXL commented Oct 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

distante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

distante Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

distante commented Oct 14, 2025

Uh oh!

distante left a comment

Choose a reason for hiding this comment

Uh oh!

distante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BETOXL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants