Skip to content

bug: (app-shortcuts) Shortcut.androidIcon unreliable#489

Merged
robingenz merged 4 commits intomainfrom
fix/issue-482
Apr 22, 2025
Merged

bug: (app-shortcuts) Shortcut.androidIcon unreliable#489
robingenz merged 4 commits intomainfrom
fix/issue-482

Conversation

@ebarooni
Copy link
Copy Markdown
Contributor

@ebarooni ebarooni commented Apr 21, 2025

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Closes: #482

ebarooni added 2 commits April 21, 2025 21:54
@ebarooni
fix(app-shortcuts): use icon names
3ffe92c 
Add `androidIconName` property to shortcut.
@ebarooni
fix(app-shortcuts): use icon names
f09e860 
Generate changeset.
@ebarooni ebarooni requested a review from robingenz April 21, 2025 19:58
@ebarooni ebarooni self-assigned this Apr 21, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 21, 2025 •
edited
Loading

Open in StackBlitz

@capawesome-team/capacitor-android-battery-optimization

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-battery-optimization@489

@capawesome/capacitor-android-dark-mode-support

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-android-dark-mode-support@489

@capawesome/capacitor-android-edge-to-edge-support

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-android-edge-to-edge-support@489

@capawesome-team/capacitor-android-foreground-service

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-foreground-service@489

@capawesome/capacitor-app-review

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-review@489

@capawesome/capacitor-app-shortcuts

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-shortcuts@489

@capawesome/capacitor-app-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-update@489

@capawesome/capacitor-asset-manager

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-asset-manager@489

@capawesome/capacitor-background-task

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-background-task@489

@capawesome/capacitor-badge

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-badge@489

@capawesome/capacitor-cloudinary

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-cloudinary@489

@capawesome-team/capacitor-datetime-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-datetime-picker@489

@capawesome-team/capacitor-file-opener

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-file-opener@489

@capawesome/capacitor-file-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-file-picker@489

@capawesome/capacitor-live-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-live-update@489

@capawesome/capacitor-managed-configurations

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-managed-configurations@489

@capawesome/capacitor-photo-editor

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-photo-editor@489

@capawesome/capacitor-posthog

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-posthog@489

@capawesome/capacitor-screen-orientation

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-screen-orientation@489

@capawesome/capacitor-screenshot

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-screenshot@489

@capawesome/capacitor-torch

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-torch@489

commit: 2ce4906

@ebarooni
fix(app-shortcuts): use icon names
c4d9ce6 
Remove `androidIconName`.
robingenz
robingenz requested changes Apr 22, 2025
View reviewed changes
Comment thread .changeset/eighty-ghosts-count.md Outdated
Comment thread packages/app-shortcuts/src/definitions.ts Outdated
Comment thread packages/app-shortcuts/example/src/js/script.js Outdated
@ebarooni ebarooni requested a review from robingenz April 22, 2025 08:54
@robingenz robingenz merged commit 34f5bc4 into main Apr 22, 2025
4 checks passed
@robingenz robingenz deleted the fix/issue-482 branch April 22, 2025 08:59
@github-actions github-actions Bot mentioned this pull request Apr 22, 2025
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@robingenz robingenz robingenz approved these changes

Assignees

@ebarooni ebarooni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: (app-shortcuts) Shortcut.androidIcon unreliable

2 participants

@ebarooni @robingenz