Fix error if local template exists: "no implicit conversion of StringIO into String" #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this problem, when I had a template in my project
config/deploy/templates/postgresql.yml.erb
.The code further up the call stack, will run
StringIO.new()
which results in a failure:capistrano-postgresql/lib/capistrano/tasks/postgresql.rake
Lines 126 to 128 in 77ae455
So in the case where
pg_template()
method returns a StringIO we see this error:The PR here fixes the bug. I saw no tests in the library, and also my rubocop noted a lot of issues in the file already.
With the lack of tests and lack of linting, please review carefully.