-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CentOS 6.x support. #45
base: master
Are you sure you want to change the base?
Conversation
@bruno- Any updates on this? That's really nice to have this for CentOs. |
Hey, |
I'm working on centos with rails and try to use this gem, however, i found out gem doesn't work on centos and this pr also. |
Hi @ereichert. Could you please rebase onto master and squash your commits? How well is this tested on CentOS and Ubuntu? |
I'll see what I can do some time this week. Regarding testing, I use it weekly on CentOS 6.5 and have never used it on Ubuntu that I recall. There is an issue with restarting unicorn after a deployment but it's not become enough of a nuisance that I'm going to do anything about it. |
…detect_os script more accurate for CentOS.
…tect_os script in the upload task. Corrected the roles for which the upload_os_detection_script task will be run. Made the upload_os_detection_script task a dependency of the setup_initializer.
…ased on whether the deployment is targeting Ubuntu or CentOS. Corrected a path that was broken during refactoring.
@rhomeister I think this is ready to go. |
I am insterested in this PR, but also saw master...erwald:38f9e9c which seems to work also with Amazon Linux. As far as I can tell, this PR doesnt work on Amazon Linux (neither Anybody having experience with this PR? |
This has been tested on CentOS 6.5 and Ubuntu 14.
Refer to https://github.com/puppetlabs/facter/blob/master/lib/facter/operatingsystem/linux.rb if additional operating systems need to be supported or more specific information about the operating system is required.