Skip to content

Conversation

ak-gupta
Copy link
Contributor

@ak-gupta ak-gupta commented Jun 2, 2025

edgetest version x.y.z

Description

In this PR, I've added a pyproject formatter to help with users' output files. I also ran edgetest.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@jdawang jdawang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request for tool configuration


[tool.setuptools]
include-package-data = true
zip-safe = false

[tool.setuptools.dynamic]
version = { attr = "edgetest.__version__" }
readme = { file = ["README.md"], content-type = "text/markdown" }
readme = { file = [
Copy link
Contributor

@jdawang jdawang Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting is weird - no changes requested just funny

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm not in love with the actual format but I figured having a formatter is generally better than not having one haha

pyproject.toml Outdated
lint.preview = true

[tool.pyproject-fmt]
column_width = 79
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff and black default to 88 - should probably do the same here just for consistency

@jdawang jdawang self-requested a review June 3, 2025 14:33
@ak-gupta ak-gupta merged commit d4fdc2d into dev Jun 3, 2025
11 checks passed
@ak-gupta ak-gupta deleted the pyproject-fmt-int branch June 3, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants