firebase upgrade to version 9.*.* #1406
Conversation
|
@WOLFIEEEE is attempting to deploy a commit to the Carbon Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request introduces 1 alert when merging d012c81 into 1395ed8 - view on LGTM.com new alerts:
|
|
Solving issue #1294 |
|
@mfix22 hey can you please review it? |
There was a problem hiding this comment.
Thanks so much for working on this @WOLFIEEEE, and so sorry for the incredible delay—I've been very busy.
Can you please run prettier against all the changes? It's difficult to assess the diff without that 🙂
Also leaving a few other nits for review, but besides that this LGTM.
Again, thanks so much!
| provider.setCustomParameters({ | ||
| allow_signup: 'true', | ||
| }) | ||
| return login(provider) | ||
| } | ||
|
|
||
| export default firebase.apps.length ? firebase : null | ||
| export default FirebaseApp |
There was a problem hiding this comment.
Can we still make this:
getApps().length ? firebase : nullso that we don't need to call getApps() in other files?
| @@ -48,7 +49,7 @@ function Drawer(props) { | |||
| function LoginButton({ isVisible, toggleVisibility }) { | |||
| const user = useAuth() | |||
|
|
|||
| if (!firebase) { | |||
| if (getApps().length === 0) { | |||
There was a problem hiding this comment.
If we make the other change suggested below, we don't need to make this change
| if (firebase) { | ||
| firebase.auth().onAuthStateChanged(newUser => setState(newUser)) | ||
|
|
||
| if(getApps().length > 0) |
Closes #1294