Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 3032: typing for translation strings #3077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix 3032: typing for translation strings #3077

wants to merge 1 commit into from
+6 −4

Conversation

klaascuvelier
Copy link
Contributor

Closes #3032

The current implementation of the TranslationStrings type does not correctly allow for nesting.
This change will fix that.

Changelog

Changed

  • fix TranslationStrings typing

@klaascuvelier klaascuvelier requested a review from a team as a code owner November 28, 2024 14:08
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 7310ce0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/67487946bd42a10008807ff2
😎 Deploy Preview https://deploy-preview-3077--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@klaascuvelier klaascuvelier mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect typedefinition for TranslationStrings (fix suggested)
1 participant
@klaascuvelier