Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all-components): add shadowparts #11812

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

Conversation

jkaeser
Copy link
Member

@jkaeser jkaeser commented May 22, 2024

Related Ticket(s)

Closes #11673

Description

This PR updates all component-internal markup to include part attributes in the shadow roots allowing global stylesheets to override internal styles.

Changelog

Changed

  • Add CSS Shadowparts

andy-blum and others added 5 commits May 21, 2024 15:33
* feat(content-group-cards): add shadowparts

* feat(content-group-cards): update unit test snapshots
* feat(background-media): add shadow parts to bg-media

* feat(background-shadow): changing part names to be more consistent

* feat(background-shadow): updating Snapshots
* feat(back-to-top-btn): adding shadow part so that the component can be styled from outside shadow

* feat(back-to-top): using a better name for the part attribute
* feat(callout-quote): add shadoe part

* feat(callout-quote): updated snapshots

* feat(callout-quote): add shadow parts to all components

* feat(callout-quote): update snapshots

* feat(callout-quote): simplify part names

* feat(callout-quote): update snapshots
@jkaeser jkaeser added owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants DO NOT MERGE shadow parts labels May 22, 2024
@jkaeser jkaeser requested a review from a team as a code owner May 22, 2024 13:15
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024

m4olivei and others added 5 commits May 22, 2024 13:48
* feat(carousel): add shadowparts

* feat(carousel): update snapshot
* feat(content-block): add shadowparts

* feat(content-block): update snapshot
* feat(card): adning shadow parts

* feat(card): refreshed the snapshots

* feat(card): ran yarn format

* feat(card): rename disabled link part
Valentin-Sorin-Nicolae and others added 30 commits May 28, 2024 14:46
* feat(expressive-modal): add shadow parts

* feat(expressive-modal): adjust part names

Co-authored-by: John Kaeser <[email protected]>

* feat(expressive-modal): update snapshot

---------

Co-authored-by: Matthew Oliveira <[email protected]>
Co-authored-by: John Kaeser <[email protected]>
* feat(global-banner): add shadow parts

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

---------

Co-authored-by: John Kaeser <[email protected]>
* feat(leaving-ibm): add shadow parts

* Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/leaving-ibm/leaving-ibm-modal-body.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/leaving-ibm/leaving-ibm-modal-body.ts

Co-authored-by: John Kaeser <[email protected]>

* feat(global-banner): add shadow parts (#11840)

* feat(global-banner): add shadow parts

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/global-banner/global-banner.ts

Co-authored-by: John Kaeser <[email protected]>

---------

Co-authored-by: John Kaeser <[email protected]>

* chore(dco): add ibm-mend-app to allowlist

* chore(dco): add ibm-mend-app to allowlist

* Add .whitesource configuration file (#11820)

Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com>
Co-authored-by: Jeff Chew <[email protected]>

* fix(side-panel): import missing icon-button and codesandbox example (#11821)

### Related Ticket(s)

Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}

### Description

Adds missing icon-button import to side-panel

Also improves the codesandbox example

### Changelog

**Changed**

- working codesandbox example
- added icon-button import to side-panel

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->

* chore(settings): update settings to v2.10.0

* chore(release): publish

 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]
 - @carbon/[email protected]

* chore(sticky-header): port refactor to v2 (#11773)

### Description
Ports changes made to feat/masthead-v2-dev branch in #11734 to v2 branch.

In order to adequately test the new Sticky Header Sandbox story, I had to clean up the Dotcom Shell stories. The `mock` secret menu item works again now, and I've reduced a good amount of bloat in the stories' markup. While I was at it, I noticed I never updated Dotcom Shell's `navLinks` prop for L0 items to Masthead's new `l0Data` prop, so I added support for that as well.

### Testing
The code changes here are mostly identical to the aforementioned PR, with the only divergences being changes necessary for v2. Please verify each of the Dotcom Shell stories works as expected, taking particular care to test the sticky elements behaviors on both desktop and mobile.

* feat(leaving-ibm): add shadow parts

* feat(global-banner): run yarn format

---------

Co-authored-by: John Kaeser <[email protected]>
Co-authored-by: Jeff Chew <[email protected]>
Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com>
Co-authored-by: Anna Wen <[email protected]>
Co-authored-by: ibmdotcom-bot <[email protected]>
* feat(notice-choice): add shadow parts

* Update packages/web-components/src/components/notice-choice/notice-choice.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/notice-choice/notice-choice.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/notice-choice/notice-choice.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/notice-choice/notice-choice.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/notice-choice/notice-choice.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/notice-choice/notice-choice.ts

Co-authored-by: John Kaeser <[email protected]>

* feat(notice-choice): add shadow parts

* feat(notice-choice): adding props in storybook

---------

Co-authored-by: Matthew Oliveira <[email protected]>
Co-authored-by: John Kaeser <[email protected]>
* chore(storybook): update shadow parts documentation

* Update packages/web-components/README.md

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/button/button.ts

Co-authored-by: John Kaeser <[email protected]>

* chore(storybook): button formating

* chore(storybook): update  existing shadow-parts documentation

* chore(storybook): update shadow parts documentation

* chore(shadow-parts): update-documentation

* chore(storybook): ran yarn format

* chore(storybook): fix parts typo

---------

Co-authored-by: John Kaeser <[email protected]>
* feat(link-list-section): add CSS shadow parts

* feat(link-list-section): add part docs
* feat(link-list): add CSS shadowparts

* feat(link-list): add part docs
* feat(logo-grid):  add shadow parts

* feat(logo-grid): add part to hr
* feat(leadspace-with-search): add shadow parts

* feat(leadspace-with-search): consistent use of back ticks in parts docs

---------

Co-authored-by: Matthew Oliveira <[email protected]>
* feat(image): shadow parts image component

* feat(image): update snapshot

* feat(image): consistent use of back ticks in parts docs
* feat(lightbox-media-view): shadow parts for all lb components

* feat(lightbox-media-viewer): update snapshot

* feat(lightbox-media-viewer): consistent use of back ticks in parts docs
* feat(leadspace): add shadow parts

* feat(leadspace): add shadow parts

* feat(leadspace): remove gradient-stop part as well

* feat(leadspace): adjustment to leadspace parts

* feat(leadspace): update snapshots

---------

Co-authored-by: Matthew Oliveira <[email protected]>
* feat(pictogram-item): add shadow parts

* feat(global-banner): add shadow parts

---------

Co-authored-by: Matthew Oliveira <[email protected]>
* feat(quote): add shadow parts

* Update packages/web-components/src/components/quote/quote.ts

Co-authored-by: John Kaeser <[email protected]>

* feat(quote): add shadow parts

* feat(quote): augment quote css parts

* feat(quote): update snapshot

---------

Co-authored-by: John Kaeser <[email protected]>
Co-authored-by: Matthew Oliveira <[email protected]>
* feat(search-with-typeahead): add shadow parts

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead-item.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead-item.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/scoped-search-dropdown-mobile.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/search-with-typeahead/search-with-typeahead.ts

Co-authored-by: John Kaeser <[email protected]>

* feat(search-with-typeahead): add shadow parts

---------

Co-authored-by: John Kaeser <[email protected]>
* feat(locale-modal): add shadow parts

* feat(locale-modal): addressing change request

* Update packages/web-components/src/components/locale-modal/locale-search.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/locale-modal/locale-search.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/locale-modal/region-item.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/locale-modal/region-item.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* feat(locale-modal): Updating documentation and snapshots

---------

Co-authored-by: Matthew Oliveira <[email protected]>
* feat(footer): add footer shadow parts

* feat(footer): adding shadow parts

* feat(footer): adding shadow parts to combo-box

* feat(footer): adding final and missing shadow parts

* feat(legal-nav): adjustments to parts

---------

Co-authored-by: Matthew Oliveira <[email protected]>
* feat(structured-list): add shadow parts

* Update packages/web-components/src/components/structured-list/structured-list-cell.ts

Co-authored-by: Andy Blum <[email protected]>

* Update packages/web-components/src/components/structured-list/structured-list.ts

Co-authored-by: Andy Blum <[email protected]>

* Update packages/web-components/src/components/structured-list/structured-list.ts

Co-authored-by: Andy Blum <[email protected]>

* feat(structured-list): add shadow parts

* feat(structured-list): add shadow parts

* feat(structured-list-group): add shadow parts

* Update packages/web-components/src/components/structured-list/structured-list-group.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* Update packages/web-components/src/components/structured-list/structured-list-group.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* feat(structured-list): adjust part names

---------

Co-authored-by: Andy Blum <[email protected]>
Co-authored-by: Matthew Oliveira <[email protected]>
* feat(video-player): add shadow parts

* feat(video-player): update snapshot

* feat(video-plaayer): add shadow parts

* feat(video-player): add shadow parts

* feat(video-player): update snapshot

---------

Co-authored-by: Matthew Oliveira <[email protected]>
* feat(table-of-content): add shadow parts

* feat(table-of-content): add shadow parts

* Update packages/web-components/src/components/table-of-contents/table-of-contents.ts

Co-authored-by: Matthew Oliveira <[email protected]>

* feat(table-of-contents): condition the list-item--active class

* feat(table-of-contents): add shadow parts

* feat(table-of-contents): condition list-item--active class

---------

Co-authored-by: Matthew Oliveira <[email protected]>
* feat(pricing-table): add shadow parts

* feat(pricing-table): add shadow parts

* Update packages/web-components/src/components/pricing-table/pricing-table-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table-header-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table-header-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table-header-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table-header-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table-header-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table-header-cell.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table.ts

Co-authored-by: John Kaeser <[email protected]>

* Update packages/web-components/src/components/pricing-table/pricing-table.ts

Co-authored-by: John Kaeser <[email protected]>

* feat(pricing-table): add shadow parts

---------

Co-authored-by: John Kaeser <[email protected]>
* feat(accordion): add shadow parts

* feat(cwc): update unit test snapshots

* feat(accordion): document shadow parts
* feat(breadcrumb): add shadow parts

* feat(breadcrumb): Shadow parts pr fixes
* chore(ui-shell): update shadow parts documentation

* chore(ui-shell): run yarn format

* chore(ui-shell): fix side nav meu

* chore(ui-shell): add shadow parts to side-nav

* docs(ui-shell): adjust casing

---------

Co-authored-by: Matthew Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants shadow parts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add part attributes to elements in the shadow DOM
7 participants