Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feature-card): remove redundant import #11957

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix(feature-card): remove redundant import #11957

merged 3 commits into from
Aug 7, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Aug 1, 2024

Related Ticket(s)

Closes #11956

Description

Fixes a redundant import, which is the kind of import that is sometimes useful when debugging / developing in the monorepo, but breaks bundling when @carbon/ibmdotcom-styles is used in isolation.

Changelog

Changed

  • Fixes bad import in the feature-card component styles

@m4olivei m4olivei added bug Something isn't working dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing labels Aug 1, 2024
@m4olivei m4olivei requested a review from a team as a code owner August 1, 2024 18:21
@m4olivei m4olivei requested review from kennylam and IgnacioBecerra and removed request for a team August 1, 2024 18:21
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 1, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11957/index.html

Built with commit: 278888feb27dfab20471678e189f0eb4894df6f5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 1, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11957/index.html

Built with commit: 278888feb27dfab20471678e189f0eb4894df6f5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 1, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11957/index.html

Built with commit: 278888feb27dfab20471678e189f0eb4894df6f5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 1, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11957/index.html

Built with commit: 278888feb27dfab20471678e189f0eb4894df6f5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 1, 2024 •
edited
Loading

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11957/index.html

Built with commit: 278888feb27dfab20471678e189f0eb4894df6f5

@kennylam kennylam added Ready to merge Label for the pull requests that are ready to merge and removed bug Something isn't working dev Needs some dev work labels Aug 7, 2024
@kodiakhq kodiakhq bot merged commit c473da2 into carbon-design-system:main Aug 7, 2024
14 of 21 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hey there! This issue/pull request was referenced in recently released v2.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@emyarod emyarod Awaiting requested review from emyarod

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
package: styles Work necessary for the Carbon for IBM.com styles package Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[styles]: Bad import causes build error for feature-card component
4 participants
@m4olivei @ibmdotcom-bot @kennylam @emyarod