refactor: rewrite IconSwitch in typescript and add types#19141
Merged
heloiselui merged 3 commits intocarbon-design-system:mainfrom Jul 16, 2025
Merged
refactor: rewrite IconSwitch in typescript and add types#19141heloiselui merged 3 commits intocarbon-design-system:mainfrom
IconSwitch in typescript and add types#19141heloiselui merged 3 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19141 +/- ##
==========================================
- Coverage 84.65% 84.65% -0.01%
==========================================
Files 373 373
Lines 14715 14713 -2
Branches 4846 4819 -27
==========================================
- Hits 12457 12455 -2
+ Misses 2108 2107 -1
- Partials 150 151 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kennylam
reviewed
Jun 25, 2025
Comment on lines
+60
to
+63
| // TODO: | ||
| // 1. Should the deprecated options be deleted? | ||
| // 2. The list doesn't include all of the options available in the | ||
| // component. Is it supposed to? |
Member
There was a problem hiding this comment.
Yes, the deprecated options should be deleted and use the new options instead. I also checked with @thyhmdo on caret alignment and confirmed that toolip placements should not include -start/-end for left/right and they should default to the center alignment.
Those alignments should be used for popover.
kennylam
approved these changes
Jun 25, 2025
Gururajj77
approved these changes
Jul 16, 2025
Merged
via the queue into
carbon-design-system:main
with commit Jul 16, 2025
2c1adee
36 checks passed
AlexanderMelox
pushed a commit
to AlexanderMelox/carbon
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Rewrote
IconSwitchin TypeScript.Changelog
New
IconSwitch.Changed
IconSwitchin TypeScript.Switchin the component docs with IconSwitch`.Testing / Reviewing
I left some
TODOs with questions that hopefully someone can answer.yarn test packages/react