Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MultiAddSelect): add floating ui to sort and filter buttons #6389

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

devadula-nandan
Copy link
Contributor

@devadula-nandan devadula-nandan commented Nov 7, 2024

Closes #6328

Blocked until there is an option to render icons / checkboxes in v12 OverflowMenu

@devadula-nandan devadula-nandan requested a review from a team as a code owner November 7, 2024 13:00
@devadula-nandan devadula-nandan requested review from elycheea and amal-k-joy and removed request for a team November 7, 2024 13:00
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 509c6b8
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67403c6ebe9f990008df881a
😎 Deploy Preview https://deploy-preview-6389--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 509c6b8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67403c6e95d7cc00083e9076
😎 Deploy Preview https://deploy-preview-6389--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.58%. Comparing base (1fe4d81) to head (ed0a84a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6389      +/-   ##
==========================================
- Coverage   79.59%   79.58%   -0.01%     
==========================================
  Files         394      394              
  Lines       12840    12840              
  Branches     4253     4253              
==========================================
- Hits        10220    10219       -1     
- Misses       2620     2621       +1     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@devadula-nandan devadula-nandan marked this pull request as draft November 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add floating ui to Sort section and filterByOpts in MultiAddSelect component
1 participant