-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CreateTearsheet): Dynamically disable/hide the experimentalSecondarySubmit button in CreateTearsheet #6412
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
==========================================
- Coverage 79.61% 79.60% -0.02%
==========================================
Files 394 394
Lines 12872 12873 +1
Branches 4268 4268
==========================================
- Hits 10248 10247 -1
- Misses 2624 2626 +2
|
…rySubmit_enhancement
…rySubmit_enhancement
@devadula-nandan Could you please review once you have time |
@matthewgallo @devadula-nandan It would be good to review this PR when you have time |
Hi @Sreejith-CS , |
@devadula-nandan Thanks for the review. I fixed the issue |
…rySubmit_enhancement
waiting for the issue to get triaged, as a first pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
…rySubmit_enhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the contribution 🎉
2eab4db
Closes #6409
Currently there is no way to disable or hide the experimentalSecondarySubmit by state change. The requirement is to disable or hide experimentalSecondarySubmit according to state change.
What did you change?
Added
experimentalSecondarySubmit
button configuration to correspondinguseEffect
hooksHow did you test and verify your work?
Manual tests via storyboard