Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tooltip from tagoverflow #6463

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

davidmenendez
Copy link
Contributor

Closes #5736

fixes an issue where the Tag component was being wrapped by a button from Tooltip which was causing an invalid dom nesting error. since carbon tags include title they should already be screen reader accessible when they are being truncated.

@davidmenendez davidmenendez requested a review from a team as a code owner November 18, 2024 19:35
@davidmenendez davidmenendez requested review from makafsal and amal-k-joy and removed request for a team November 18, 2024 19:35
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit fa75f92
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/673e430b68097d0008b4cf65
😎 Deploy Preview https://deploy-preview-6463--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit fa75f92
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/673e430b7f3c32000855b634
😎 Deploy Preview https://deploy-preview-6463--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (7428bdf) to head (710eea1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6463      +/-   ##
==========================================
+ Coverage   79.59%   79.61%   +0.01%     
==========================================
  Files         394      394              
  Lines       12871    12871              
  Branches     4268     4268              
==========================================
+ Hits        10245    10247       +2     
+ Misses       2626     2624       -2     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)
---- 🚨 Try these New Features:

Copy link
Member

@makafsal makafsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Codecov, I think we need to write some tests.

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but found one glitch.
With this change we are unable to tab navigate through the tags. Since you removed Tooltip wrapper , removed button elements as well that made it not focusable i guess.

@davidmenendez
Copy link
Contributor Author

@amal-k-joy this appears to be working as intended as they are read only

@davidmenendez
Copy link
Contributor Author

@makafsal coverage should be acceptable now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tagoverflow: dom nesting and tooltip accessibility
3 participants