Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependency action to use carbon bot/app token #6498

Merged

Conversation

matthewgallo
Copy link
Member

Closes #6497

Uses same token approach as Core to open PRs so that it is opened by one of the Carbon github bots/apps. I also removed the slack integration piece since it doesn't work and wanted to do some cleanup.

What did you change?

.github/workflows/update.yml

How did you test and verify your work?

Haven't been able to yet! But the same APP_ID and APP_PRIVATE_KEY secrets have been added to our repo that are also used in core and those are used to generate the token used by peter-evans/create-pull-request.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 23ac446
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/673f7bf3fd7b830008c7b5b5
😎 Deploy Preview https://deploy-preview-6498--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 23ac446
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/673f7bf36a616100084188d7
😎 Deploy Preview https://deploy-preview-6498--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (01ece2b) to head (23ac446).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6498   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files         394      394           
  Lines       12886    12886           
  Branches     4268     4268           
=======================================
  Hits        10263    10263           
  Misses       2623     2623           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@matthewgallo matthewgallo changed the title build: update dependency action to use carbon bot token build: update dependency action to use carbon bot/app token Nov 21, 2024
davidmenendez
davidmenendez previously approved these changes Nov 21, 2024
Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I see you’re preparing to get yourself back into dependencies rotation. 😜

I think I consider dependencies more of a chore, although I guess based on the Angular conventions1, build still seems appropriate. Maybe a good thing if we get more specific with our commit formats though than calling everything a chore. (I’m guilty of that too.)

Footnotes

  1. https://github.com/angular/angular/blob/main/CONTRIBUTING.md#-commit-message-format

@matthewgallo
Copy link
Member Author

Yes! I'm coming off the bench 😂 I went to add an approval to #6437 and realized that I couldn't since it was opened by me (my guess is that maybe I created the token that's currently passed to peter-evans/create-pull-request).

Both chore and build seem like valid options and I've seen both used across various different projects, happy to stick with build 👍

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, thanks for letting my air out my commit type thoughts. 😹 WELCOME BACK *to dependency land.

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@elycheea elycheea added this pull request to the merge queue Nov 26, 2024
Merged via the queue into carbon-design-system:main with commit 1e8818f Nov 26, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency PRs so that the author is from a carbon bot
3 participants