-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update dependency action to use carbon bot/app token #6498
build: update dependency action to use carbon bot/app token #6498
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6498 +/- ##
=======================================
Coverage 79.64% 79.64%
=======================================
Files 394 394
Lines 12886 12886
Branches 4268 4268
=======================================
Hits 10263 10263
Misses 2623 2623
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I see you’re preparing to get yourself back into dependencies rotation. 😜
I think I consider dependencies more of a chore
, although I guess based on the Angular conventions1, build
still seems appropriate. Maybe a good thing if we get more specific with our commit formats though than calling everything a chore
. (I’m guilty of that too.)
Footnotes
Yes! I'm coming off the bench 😂 I went to add an approval to #6437 and realized that I couldn't since it was opened by me (my guess is that maybe I created the token that's currently passed to Both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, thanks for letting my air out my commit type thoughts. 😹 WELCOME BACK *to dependency land.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
1e8818f
Closes #6497
Uses same token approach as Core to open PRs so that it is opened by one of the Carbon github bots/apps. I also removed the slack integration piece since it doesn't work and wanted to do some cleanup.
What did you change?
How did you test and verify your work?
Haven't been able to yet! But the same
APP_ID
andAPP_PRIVATE_KEY
secrets have been added to our repo that are also used in core and those are used to generate the token used bypeter-evans/create-pull-request
.