fix(pageHeader): menu button overflow issue on small screens #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devadula-nandan
requested review from
davidmenendez and
sangeethababu9223
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6502 +/- ##
=======================================
Coverage 79.65% 79.65%
=======================================
Files 394 394
Lines 12871 12871
Branches 4257 4257
=======================================
Hits 10253 10253
Misses 2618 2618
|
davidmenendez
approved these changes
Nov 26, 2024
|
Hi @davidmenendez , @sangeethababu9223 . 
|
Approved. |
Merged
via the queue into
carbon-design-system:main
with commit Nov 27, 2024
0072e42
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6415
fixes menu button overflow issue in firefox in small screen
What did you change?
packages/ibm-products-styles/src/components/PageHeader/_page-header.scss
How did you test and verify your work?
storybook, firefox